AVPlayerLayer videoGravity support on iOS #10
Conversation
bedemiralp
commented
Jun 22, 2018
bedemiralp
commented
- adding resizeAspectFill prop to preserve the video's aspect ratio and fill the layer's bounds on iOS
- updating the prop list in README.md
- adding resizeAspectFill prop to index.d.ts file
- changing iOS Deployment Target setting to 9.0 (was 11.2)
…nd fill the layer's bounds on iOS * updating the prop list in README.md * adding resizeAspectFill prop to index.d.ts file * changing iOS Deployment Target setting to 9.0 (was 11.2)
There was a problem hiding this comment.
Thank you for contributing.
For Android, I think that fixing this part can provide the same function.
Would you please fix it ?
https://github.com/manse/react-native-brightcove-player/blob/master/android/src/main/java/jp/manse/BrightcovePlayerView.java#L233-L242
index.d.ts
Outdated
| @@ -14,6 +14,7 @@ export type Props = { | |||
| onEnd?: () => void; | |||
| onProgress?: ({ currentTime: number }) => void; | |||
| style?: ViewStyle; | |||
| resizeAspectFill: boolean; | |||
There was a problem hiding this comment.
This prop is optional. Please add ?
There was a problem hiding this comment.
Thank you for pointing this out. I fixed it.
There was a problem hiding this comment.
Thank you.
Is it possible to implement Android?
Thank you for contributing.
For Android, I think that fixing this part can provide the same function.
Would you please fix it ?
https://github.com/manse/react-native-brightcove-player/blob/master/android/src/main/java/jp/manse/BrightcovePlayerView.java#L233-L242
There was a problem hiding this comment.
Sure thing. It may be possible. I will give it a try.
Implemented the setFullscreen on rotation
iOS - Fairplay
