Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TapeAdapter: Add new adapter for tape #132

Closed
wants to merge 3 commits into from
Closed

TapeAdapter: Add new adapter for tape #132

wants to merge 3 commits into from

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Feb 15, 2021

Ref #118.

@Krinkle Krinkle requested a review from ljharb February 15, 2021 02:25
ljharb
ljharb reviewed Feb 15, 2021
View reviewed changes
Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to add tests where the callback returns a Promise (both rejected and fulfilled), as well as tests that use t.plan() instead of t.end().

lib/adapters/TapeAdapter.js Outdated Show resolved Hide resolved
lib/adapters/TapeAdapter.js Outdated Show resolved Hide resolved
Krinkle and others added 2 commits February 16, 2021 00:39
@Krinkle
Copy link
Member Author

Krinkle commented Feb 21, 2021

Closing in favour of #133. I'll try to keep the js-reporters spec instead compatible with what existed before, and reduce its use to adapting framework toward TapReporter (instead of adapting from already-TAP-capable frameworks toward the CRI event model).

@Krinkle Krinkle closed this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krinkle @ljharb