Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Resolves an issue fisher failing #609

Closed
wants to merge 1 commit into from
Closed

Resolves an issue fisher failing #609

wants to merge 1 commit into from

Conversation

edheltzel
Copy link

The command fisher update is no longer supported by Fisher.
To update Fisher the command is now fisher

Standards checklist:

  • The PR title is descriptive.
  • The code compiles
  • The code passes rustfmt
  • The code passes clippy
  • The code passes tests
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

- fisher no longer supports `fisher update`
the new command is to just run `fisher`
@r-darwish
Copy link
Owner

The documentation says that fisher update should be ran

@edheltzel
Copy link
Author

edheltzel commented Jan 29, 2021

The documentation says that fisher update should be ran

The docs are outdated -

this is the result of fisher update

~
❯ fisher update
fisher: unknown flag or command "update"
usage: fisher add <package...>     Add packages
       fisher rm  <package...>     Remove packages
       fisher                      Update all packages
       fisher ls  [<regex>]        List installed packages matching <regex>
       fisher --help               Show this help
       fisher --version            Show the current version
       fisher self-update          Update to the latest version
       fisher self-uninstall       Uninstall from your system
examples:
       fisher add jethrokuan/z rafaelrinaldi/pure
       fisher add gitlab.com/foo/bar@v2
       fisher add ~/path/to/local/pkg
       fisher add <file
       fisher rm rafaelrinaldi/pure
       fisher ls | fisher rm
       fisher ls fish-\*

according to the help info running just fisher will update all plugins.
I also have an issue reported with Fisher but it is unrelated to Topgrade.

Copy link
Contributor

@jorgebucaran jorgebucaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edheltzel You happen to be running an old Fisher. We don't need to change anything here. 😉

@edheltzel
Copy link
Author

@jorgebucaran thanks!

@edheltzel edheltzel closed this Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants