This PR adds Oil temperature data to MQB clusters #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on work by adam-ht
|
Can you make the minimum and maximum configurable? See the ClusterConfiguration struct (in GameSimulation.h) for an example of how it's done for coolant temperature. I am guessing this won't be the first or the last cluster with support for oil temperature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on @adam-ht's work
notes: values below 50c show up as
---Con the cluster, and values above 192c make the panel disappear until a smaller value is sent.constrain() is used to avoid an overflow due to the offset