Fix constructor-style printing for hashes. #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes racket#220. Wrap a struct around hashes that has a custom print-converter. NOTE: While this works correctly in the #langs, this fails the tests in htdp-test/tests/htdp-lang/advanced.rktl, as they pick up the correct binding for make-hash, but not for make-copy etc.
|
I could use some help with this PR: I don't know why the tests pick up the correct binding for |
|
I think we probably want to change some printing code for the existing
hashes, not make a new struct. With a new struct then others' libraries
won't work right anymore.
Robby
|
|
@rfindler Sure - but I think this reveals that the concept of print-convert is ultimately flawed, as you really need to parameterize everything about it. It would be better to be able to register a lang-specific function that does all of the work, and maybe provide a library of helpers that this function could call. |
|
@rfindler Bump ... on adding the necessary option to print-convert, as discussed today. |
|
I've pushed a fix for #220 by changing print convert instead of this strategy. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220.
Wrap a struct around hashes that has a custom print-converter.
NOTE: While this works correctly in the #langs, this fails the tests in htdp-test/tests/htdp-lang/advanced.rktl, as they pick up the correct binding for make-hash, but not for make-copy etc.