-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test pydantic #178
Draft
cchall
wants to merge
90
commits into
develop
Choose a base branch
from
test_pydantic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test pydantic #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble and simulation setup
…d for spiffe. elegant matching example also tested with the updated param/setting name parsers
…ate layed out by the spiffe implementation. Some adaptation is needed since Genesisv2 does not need multiple commands.
…pes in the model dump so that Genesis is happy with the input file. Corrected a name error for Parameter index field in several places.
…tion registry to handle special cases during the file formatting. Added some missing fields to the validation that were caught after turning off exclude.
…el getters work properly once there are multiple names sharing a typing.
…lass updates to getters.
…for introspection.
…. Tested with MAD-X scan.
…ss into python functions. Adds significant convenience if there are many arguments being passed into the function.
…t can all share a single name.
…tatic so we won't validate that one or the other dynamic or static is set.
…in field which was massing and creating a mysterious error in the allocator.
…un files or sym links when the python process is run directly on the worker.
…, for how to handler software options with multiple methods. Primary issue is making sure that software_options is validated based on the input to the method field. Using a model validator seems to retain the common checks to inputs and still provide useful error message while validating the software_options by method.
…class. Originally libEnsembleOptimizer handled all local optimizers but this gets messy if you want to handle slight variations in user-spec between scipy, dfols, and nlopt. Going forward will use separate classes for each.
…n works. Missing some capabilities such as reload from file and marking X_pending. Some useful generator parameters cannot yet be passed through.
…t be defined in multiple places any longer. This also means that option_spec for the Method classes needs to become a requirement of its ABC and should no longer be private.
# Conflicts: # rsopt/configuration/options/dfols.py # rsopt/configuration/options/nlopt.py # rsopt/configuration/options/scipy.py # rsopt/configuration/schemas/options.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.