Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listen 2 support. #3

Merged
merged 1 commit into from
Jun 26, 2015
Merged

Add listen 2 support. #3

merged 1 commit into from
Jun 26, 2015

Conversation

cduez
Copy link
Contributor

@cduez cduez commented Jun 26, 2015

This solve #1.

All work was done here rails/spring#194.

We are actually using it and everything is working as expected.

Signed-off-by: Cyril Duez <[email protected]>
Signed-off-by: chatgris <[email protected]>
@e2
Copy link
Contributor

e2 commented Jun 26, 2015

Thanks for putting this together!

There's a few issues not related to the patches themselves, but I think this can be released anyway in the meantime.

The issues:

  • there's a patch for the fork() problem in Celluloid, but it never got backported
  • there's an upcoming optimized version of Listen 3.0, but it's not released yet
  • there's a listen-compat library, which is supposed to wrap Listen, so that any version can be used

Anyway, thanks for moving this forward!

e2 added a commit that referenced this pull request Jun 26, 2015
@e2 e2 merged commit 7f6003e into rails:master Jun 26, 2015
@e2
Copy link
Contributor

e2 commented Jun 27, 2015

@cduez - spring-watcher-listen released (2.0.0) and Listen is updated (3.0.0) - together they should work faster and without issues. (Let me know if you have any).

@cduez
Copy link
Contributor Author

cduez commented Jun 29, 2015

Thanks for the release and the update! I will test it asap.

@pjg
Copy link

pjg commented Jul 2, 2015

This is awesome! No, it's even beyond awesome!

(PS: quick tests show that this works as intended)

@e2
Copy link
Contributor

e2 commented Jul 2, 2015

@pjg - thank @cduez for PR.

Do report any issues you find with Listen 3.x, since it's a major, major rewrite.

@pjg
Copy link

pjg commented Jul 2, 2015

Yes, thank you @cduez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants