Require sprockets deprecator in Railtie #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 6, 2024
sprockets-rails 3.5.0 breaks our test suite. See rails/sprockets-rails#524 and rails/sprockets-rails#525
yahonda
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Can we remove "require 'active_support'" from this file?
With the release of sprockets-rails 3.5.0, our local test suite breaks with ``` NoMethodError: undefined method `deprecator' for Sprockets::Rails:Module /home/circleci/solidus/vendor/bundle/ruby/3.2.0/gems/sprockets-rails-3.5.0/lib/sprockets/railtie.rb:129:in `block in <class:Railtie>' ``` This should fix that by explicitly requiring the `Sprockets::Rails.deprecator` in both `lib/sprockets/rails.rb` and `lib/sprockets/railtie.rb`. Should fix rails#524
mamhoff
force-pushed
the
require-deprecator-in-railtie
branch
from
fa7dc71
to
d34e89c
Compare
yahonda
added a commit
to rails/rails
that referenced
this pull request
Jun 7, 2024
|
Thanks for the update. I have pushed a commit to see if this pull request addresses Rails CI failures https://buildkite.com/rails/rails/builds/108096 |
tvdeyen
added a commit
to tvdeyen/alchemy-devise
that referenced
this pull request
Jun 7, 2024
|
Ah thank you I was doing exactly the same thing :) Seems like there is still one test fialing on the Rails side, but I'll investigate it. |
Hum, I can't seem to repro it locally 🤔 |
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Jun 7, 2024
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of sprockets-rails 3.5.0, our local test suite breaks with
This should fix that by explicitly requiring the
Sprockets::Rails.deprecatorin bothlib/sprockets/rails.rbandlib/sprockets/railtie.rb.Fix #524