readlines must be called on stderr first

railsbump · Mar 10, 2024 · a257a39 · a257a39
1 parent 79783e4
commit a257a39
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/services/compats/check.rb b/app/services/compats/check.rb
@@ -118,9 +118,10 @@ def check_with_bundler_locally
           SCRIPT
           File.chmod 0755, file
 
-          stdout, stderr = Bundler.with_unbundled_env do
+          stderr, stdout = Bundler.with_unbundled_env do
             Open3.popen3 file.to_s do
-              [_2, _3].map do |io|
+              # For some reason, the order matters: readlines must be called on stderr first. 🤷‍♂️
+              [_3, _2].map do |io|
                 io.readlines.map(&:strip)
               end
             end