Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ts4 support #115

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Fix: ts4 support #115

merged 2 commits into from
Mar 30, 2024

Conversation

Harris-Miller
Copy link
Collaborator

@Harris-Miller Harris-Miller commented Mar 29, 2024

I can't believe I fucked this up: 8f80f42#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

While testing to see if this worked

  "typesVersions": {
    "<5": {
      "index.d.ts": [
        "ts4/index.d.ts"
      ],
      "*": [
        "ts4/*"
      ]
    }
  },

I was adding/removing it locally while testing it against a local repo with typescript@4. It worked as expected, and then, with it still removed, committed it 🤦

This will re-fix ts4 support

How I tested this

  • Pull this repo: https://github.com/Harris-Miller/ramda-ts4-test and npm ci
  • It's a simple project that uses the 2 ts@5 only functions pick and omit
  • The project has ts@4 installed, so npm run build will have typescript errors
  • Pull down this branch, npm run build
  • Using yalc, do yalc publish
  • back over in ramda-ts4-test do yalc link types-ramda
  • do npm run build again see the type errors are gone

@Harris-Miller Harris-Miller merged commit 5b758ca into develop Mar 30, 2024
3 checks passed
@Harris-Miller Harris-Miller deleted the ts4-fix branch March 30, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant