-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.11] rancher-logging 106.0.0-rc.1+up4.10.0-rancher.2 update #5212
base: dev-v2.11
Are you sure you want to change the base?
[dev-v2.11] rancher-logging 106.0.0-rc.1+up4.10.0-rancher.2 update #5212
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not correct - first the PR in ob-team-charts
should be corrected for feedback, then merged.
After that, this repo should only need to be updated to:
- In
package.yaml
update the upstream chart version to use the newob-team-charts
version for this chart. - Also increment the "rancher/charts local" RC version,
- Do the normal make {prepare,patch,charts} steps.
So the end result will be a version that looks something like: 106.0.0-rc.2+up4.10.0-rancher.2
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
…-rancher.2 Signed-off-by: Meza <[email protected]>
de58f74
to
271c106
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Hi @mallardduck I've made the updates you requested. Please let me know if I did anything wrong. Thanks and apologies for the delay! |
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Checkpoints for Chart Bumps
release.yaml
:Chart.yaml and index.yaml
:index.yaml
file has an entry for your new chart version.index.yaml
entries for each chart matches theChart.yaml
for each chart.Issue:
rancher/rancher#49048 && SURE-9662
Solution
Added priorityClassName to DS resources for k3s/rke/rk2 only if value is populated in values.yaml. We should also backport this to rancher-logging 105 on dev-v2.10 branch.
{{- with .Values.priorityClassName }} priorityClassName: {{ . }} {{- end }}
Added podPriorityClassName in Logging/FluentBitAgent generic templates with the option to set it in the global or fluentd/fluentbit keys.
QA Testing Considerations
Example values.yaml used for testing. Comment out the
podPriorityClassName
to testpriorityClassName: global-level-test
is passed down to all resources.