Embed example clusterclasses in e2e suite #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
previously approved these changes
Mar 20, 2025
4 tasks
salasberryfin
previously approved these changes
Mar 21, 2025
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
dismissed stale reviews from salasberryfin and anmazzotti
via
de0f070
alexander-demicev
force-pushed
the
embedexamples
branch
from
5266a07 to
de0f070
Compare
alexander-demicev
requested review from
Danil-Grigorev,
salasberryfin and
anmazzotti
|
@alexander-demicev I would actually close this PR due to #1171 |
|
@anmazzotti but we can still set the separate clusterclass namespace with embedded files |
anmazzotti
approved these changes
Mar 21, 2025
Danil-Grigorev
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Embed example clusterclasses in e2e suite, this should the code more readable
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: