Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep fleet addon CAPIProvider name #1214

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:

Keep original CAAPF CAPIProvider name, since this change has issues with deletion of the previous, and is mostly cosmetical.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1206

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner March 26, 2025 13:38
@Danil-Grigorev Danil-Grigorev added kind/bug Something isn't working area/fleet labels Mar 26, 2025
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe one workaround to this would be having a pre-(install/upgrade) helm job to uninstall the old addon provider if exists?

@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) March 26, 2025 13:59
@Danil-Grigorev Danil-Grigorev merged commit 7b668c6 into rancher:main Mar 26, 2025
9 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate FleetAddon providers installed after turtles upgrade
3 participants