Regular withdrawal #167
Merged
Regular withdrawal #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered that adding LineItems to an unsaved Transaction doesn't work for more than one line item, so had to change approach by using `put_assoc` when creating the initial changeset. Will refactor other transactions to match in follow-up commits. Reusing the `SingleTransactionForm`, which had almost everything needed. Will rename in a follow-up. Couldn't find a great way to get the fund names to use as field labels, so using `Enum.at` for now.
It's no longer needed.
Includes testing that unfilled lines are ignored and showing a higher-level error message when all lines are unfilled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the regular withdrawals feature.
While doing this, I discovered that adding LineItems to an unsaved Transaction doesn't work for more than one line item, so I had to change approach by using
put_assocwhen creating the initial changeset. I refactored the single-fund deposit and withdrawal transactions to match the same pattern.Reused the
SingleTransactionForm, which had almost everything needed so renamed it toTransactionForm.I couldn't find a great way to get the fund names to use as field labels, so using
Enum.atfor now.I'm using the
action: ignorefeature of Ecto to ignore any line items that have missing or zero amounts. The net result has too much error feedback on the form, but I'm going to live with that for now.Closes #102
Checklist
Have you added the following where appropriate?