Adjust keep_cols logic
#109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
commented
Jan 16, 2025
| query_id = f"q{i+1}" | ||
| query_id = f"q{i + 1}" |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108.
I have found that setting
op.Labeler(labels, cols=[prob_col], keep_cols=[prob_col], suffix=label_col)allows the probability column to be kept (without having to specifydf[prob_col] = 0) and settingop.Labeler(labels, cols=[prob_col], suffix=label_col)allows the user the drop the probability column.My confusion from before came because I would try to set
keep_cols=[label_col, prob_col]which would cause an error because thelabel_coldoes not exist yet. Thus, if the user attempts to pass the label column (i.e.,suffix) intokeep_cols, I think that CrossFit should automatically drop it out ofkeep_cols, since the label column is kept no matter what.