Plumb metric and metric_kwds through to UMAP with nn_descent
#6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using `L2Unexpanded`/`L2SqrtUnexpanded`, which are more costly.
Previously we were using `L2SqrtUnexpanded`, which is more costly.
Previously we were using `L2SqrtUnexpanded`, which is more costly.
Previously we were erroneously missing this plumbing, leaving the `metric` and `metric_arg` as the defaults when `nn_descent` is used. In the long run we should redo how the parameters are passed when `nn_descent` is enabled to avoid this duplication, but for now fixing the plumbing to be more correct seems fine.
At least on my aarch64 linux box these aren't failing anymore.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jcrist
added
bug
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were erroneously missing this plumbing, leaving the
metricandmetric_argas the defaults whennn_descentis used. In the long run we should redo how the parameters are passed whennn_descentis enabled to avoid this duplication (there's a few other uselessly exposed params likereturn_distances), but for now fixing the plumbing to be more correct seems fine.On top of #6303, leaving as draft for now until that's merged.
Also re-enables tests on ARM, fixes #5441.