Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build reliability #725

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Jan 14, 2025

Separates the workflows for building the RAPIDS end user images and the cuVS images. The cuVS images do not depend on the RAPIDS end user images, so they can be built in parallel. This also allows for finer grained retries in case of failures.

Also switches to using rapids-mamba-retry for installing conda packages.

Finally, disables building the cuvs-bench-datasets images which are consistently failing (#724) until a better solution than the workaround in #723 is ready. 5adab54 can be reverted to re-enable this.

@raydouglass raydouglass changed the title Separate building RAPIDS & cuVS images Improve build reliability Jan 14, 2025
@raydouglass
Copy link
Member Author

The test failures should be unrelated and are probably new changes in 25.02 that have to be addressed in cuspatial.

@raydouglass raydouglass marked this pull request as ready for review January 15, 2025 17:55
@raydouglass raydouglass requested a review from a team as a code owner January 15, 2025 17:55
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raydouglass
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b2701d6 into rapidsai:branch-25.02 Jan 15, 2025
61 of 64 checks passed
@raydouglass raydouglass deleted the separate-rapids-cuvs branch January 15, 2025 20:24
@jakirkham
Copy link
Member

Thanks Ray and Jake! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants