Introduce Router.In, Router.Out, Router.Shared and Router traits
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquo
reviewed
Feb 24, 2025
raquo
reviewed
Feb 25, 2025
| /** The covariant side of the router. */ | ||
| trait Out[+BasePage] extends Shared { | ||
| /** @see [[Router.currentPageSignal]] */ | ||
| def currentPageSignal: StrictSignal[BasePage] |
There was a problem hiding this comment.
Latest version LGTM except that def currentPageSignal and def origin both should be val-s. The origin is not supposed to be lazy or changeable, and currentPageSignal can't really be implemented as a def because it pretty much has to have side effects inside (so if we did implement it as a def, it would likely be incorrect) (also there should be no reason to implement it as a def).
|
Anything else to do here @raquo ? |
|
All is good, just need to find the time to merge & release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord discussion: https://discordapp.com/channels/1020225759610163220/1020226231834255390/1340436623640367115