-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support alibaba cloud rrsa store auth provider #1909
Conversation
Codecov ReportAttention: Patch coverage is
|
0452b84
to
802b77d
Compare
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
9338d47
to
af6bfa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DahuK ,
thanks so much for adding the alibaba auth provider. The group of us have discussed during the PR review meeting, and here are the notes:
- we are aiming for unit test coverage at 80%, would it be possible to add more coverage for alibabacloudacrauthtypes.go and alibabacloudacrbasic.go
- maybe as a sperate PR, are you looking to add e2e test similar to azure-test.bats
- also as a seperate PR, might be good to add to auth provider docs at supported auth providers
Hi @DahuK ,please also review the lint report and resolve the merge conflict. let us know if you have any questions |
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrauthtypes.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrauthtypes.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
af6bfa4
to
423d988
Compare
ff17ccc
to
3426cde
Compare
Thanks your reviewing and sorry for the late response!
|
3426cde
to
dcaf03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some minor comments, lgtm overall
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrauthtypes.go
Outdated
Show resolved
Hide resolved
a36efd0
to
c653ea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update! left some clarification questions
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
pkg/common/oras/authprovider/alibabacloud/alibabacloudacrbasic.go
Outdated
Show resolved
Hide resolved
8dcc3f1
to
3766140
Compare
Hi @DahuK , thanks for the latest updates, the change looks good. Please resolve the latest go.mod conflicts , this PR is almost ready to merge. @junczhu , @binbin-li please take a look if conversation should be resolved. thanks all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for adding support for alibaba and unit tests!
@DahuK the PR is good to go, could you sign the commit following it: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
2ad167f
to
a883ce3
Compare
Signed-off-by: dahu.kdh <[email protected]>
a883ce3
to
65cd6ab
Compare
Thanks! the commit is signed. |
Description
What this PR does / why we need it:
Support using Alibaba Cloud RAM Roles for Service Accounts(RRSA) to pull artifacts from a private Alibaba Cloud Container Registry (ACR) with an ACR specific auth token.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
In addition, I have local built the testing image contains the changes in this PR,and tested in the Alibaba Cloud ACK cluster to verify fetch the signature metadata of a private images in the Aliababa Cloud ACR repository by using the store authProvider based on the new RRSA configuration. The more instructions will be added in the subsequent document PR.
Checklist:
Post Merge Requirements
Helm Chart Change