fix: FaaS error case #922
Merged
fix: FaaS error case #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
previously approved these changes
Dec 16, 2021
ClarkXia
reviewed
Dec 16, 2021
| @@ -6,5 +6,6 @@ export default function formatEntryLoaderQuery(query: ILoaderQuery): IFormattedL | |||
| needInjectStyle: query.needInjectStyle === 'true', | |||
| updateDataInClient: query.updateDataInClient === 'true', | |||
| pageConfig: JSON.parse(query.pageConfig as string || '{}'), | |||
| injectedHTML: JSON.parse(query.injectedHTML || '{}'), | |||
There was a problem hiding this comment.
inline 方式不宜传入过多参数，node 下会有最大长度路径的限制，后面可能需要优化下
There was a problem hiding this comment.
ok，后面考虑和 icejs 方案一致 #910
chenjun1011
approved these changes
Dec 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=======================================
Coverage 31.60% 31.60%
=======================================
Files 46 46
Lines 1174 1174
Branches 280 280
=======================================
Hits 371 371
Misses 803 803 |
SoloJiang
added a commit
that referenced
this pull request
Dec 22, 2021
This reverts commit f2f7a98.
SoloJiang
added a commit
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devServer.hotfor mockrequirecase__CHUNK_INFO__beforedevServerreturnhtml, for FaaS executerendermethod manuallyfile-loaderwithurl-loader