Best practice for fault-tolerant redis with kuberay #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Currently, we add the KubeRay documentation to the Ray repository so that it will automatically appear on the Ray website at https://docs.ray.io/en/latest/cluster/kubernetes/user-guides.html. Would you mind opening a PR to the Ray repository for the documentation and leaving this PR only for the YAML?
|
Then, you can cc @rueian and me to review. Thanks! |
rueian
reviewed
Dec 28, 2024
rueian
reviewed
Dec 28, 2024
|
Hi @spencer-p, LGTM mostly. Thanks for the nice doc. |
Of course. I had figured that would be the next step. To be clear we want to omit this from the best-practice dir in this repo entirely? |
- Suggest disabling AOF on gcsfuse, s3 - Update redis version - Don't provide a default storageClass
|
Doc is at ray-project/ray#49887, will remove from this PR |
rueian
approved these changes
Jan 29, 2025
andrewsykim
approved these changes
Jan 29, 2025
Ygnas
pushed a commit
to Ygnas/kuberay
that referenced
this pull request
Mar 20, 2025
* Draft kuberay + redis + persistent volume best practice * Address review comments 1 - Suggest disabling AOF on gcsfuse, s3 - Update redis version - Don't provide a default storageClass * Remove best practice doc for gcs/redis/disk Moved to ray-project/ray#49887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Addresses #2582
Related issue number
Closes #2582
Checks