-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Add Vale configuration #35916
Conversation
This reverts commit 5984f1e.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
This reverts commit de05655. Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
This literally gives me the warm fuzzies. Thank you so much, @bveeramani and @amogkam! One request, @bveeramani, is there a way to standardize how we tell readers to "see" another doc, vs "read, go to, check out, etc." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits.
All credit goes to @bveeramani! Great work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data doc changes lgtm
Address review comments Signed-off-by: Balaji Veeramani <[email protected]>
Update dashes Signed-off-by: Balaji Veeramani <[email protected]>
Remove trailing newine Signed-off-by: Balaji Veeramani <[email protected]>
This PR adds configuration for Vale -- a linting tool that helps us enforce a consistent editorial style. To use Vale, either install the VSCode extension for Vale or run vale doc/source/data. In a future PR, we plan to enforce Vale in CI (starting with the Data documentation). Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: e428265 <[email protected]>
This PR adds configuration for Vale -- a linting tool that helps us enforce a consistent editorial style. To use Vale, either install the VSCode extension for Vale or run vale doc/source/data. In a future PR, we plan to enforce Vale in CI (starting with the Data documentation). Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Victor <[email protected]>
Why are these changes needed?
This PR adds configuration for Vale -- a linting tool that helps us enforce a consistent editorial style. To use Vale, either install the VSCode extension for Vale or run
vale doc/source/data
.In a future PR, we plan to enforce Vale in CI (starting with the Data documentation).
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.