[core][dashboard] make a flamegraph on event loop lag. #47491
+179
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <[email protected]>
|
TODO: do log rotation: only keep N graphs |
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
|
@jjyao I added log rotation for the graphs, PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ray Dashboard is important yet struggles with the event loop blocked by various code. This PR introduces a feature to let it profile itself into flamegraph when the event loop lag is high. Default disabled.
How it works: we have 3 args: ON_LAG, DURATION, COOLDOWN. If lag is > ON_LAG, profile for DURATION secs, then sleep for COOLDOWN and monitor the lags again.
Also renamed the generated svg files to include date and time, to avoid overwriting the past flamegraphs.