Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] add SingleAgentRLModuleSpec alias to RLModuleSpec #47560

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kakadus
Copy link

@Kakadus Kakadus commented Sep 8, 2024

Why are these changes needed?

Allows restoring Algorithm instances from old checkpoints using the Algorithm.from_checkpoint api.

Related issue number

Closes #47426

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Kakadus
Copy link
Author

Kakadus commented Sep 8, 2024

I manually created a checkpoint with ray v2.34.0 and loaded it successfully using these changes.

@@ -11,6 +11,7 @@
MultiAgentRLModuleConfig = MultiRLModuleConfig
MultiAgentRLModuleSpec = MultiRLModuleSpec

# ray.rllib.core.rl_module.rl_module.SingleAgentRLModuleSpec is also deprecated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know how to mark the alias as deprecated, so I just added a comment to the other related aliases.

…algorithms from old checkpoints

Signed-off-by: Jonas Dittrich <[email protected]>
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) rllib RLlib related issues labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rllib RLlib related issues triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] Rename of SingleAgentRLModuleSpec to RLModuleSpec breaks restoring old checkpoints
2 participants