Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[aDAG] support buffered input (#47272)" #47611

Closed
wants to merge 1 commit into from
Closed

Revert "[aDAG] support buffered input (#47272)" #47611

wants to merge 1 commit into from

Conversation

rkooo567
Copy link
Contributor

This reverts commit f40313b.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 requested a review from a team as a code owner September 11, 2024 16:34
@rkooo567 rkooo567 enabled auto-merge (squash) September 11, 2024 17:57
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 11, 2024
@rkooo567
Copy link
Contributor Author

cc @angelinalg can you approve the doc change? (it is revert)

angelinalg
angelinalg approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@rkooo567
Copy link
Contributor Author

will merge try-reducing-buffer-size instead

@rkooo567 rkooo567 closed this Sep 14, 2024
auto-merge was automatically disabled September 14, 2024 05:44

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@ruisearch42 ruisearch42 ruisearch42 approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkooo567 @angelinalg @ruisearch42