[WIP][ADAG]Enable NPU (hccl) communication for aDAG #47658
+196
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhilong <[email protected]>
Bye-legumes
changed the title
|
cc @ruisearch42 |
ruisearch42
reviewed
Sep 16, 2024
| from ray.experimental.channel.nccl_group import _NcclGroup | ||
|
|
||
| else: | ||
| from ray.experimental.channel.hccl_group import _HcclGroup as _NcclGroup |
There was a problem hiding this comment.
hmm, this looks like a hack. Do you plan to change to a cleaner approach?
| @@ -16,7 +16,7 @@ | |||
| @DeveloperAPI | |||
| class GPUCommunicator(ABC): | |||
| """ | |||
| Communicator for a group of aDAG actors on Nvidia GPU. | |||
| Communicator for a group of aDAG actors on Nvidia GPU or other XPUs. | |||
There was a problem hiding this comment.
We should probably change the class name to a more general one if this is to support other XPUs. This is not yet used externally so backward compatibility is not an issue.
| self._device_id = device_id | ||
|
|
||
| if rank is not None: | ||
| assert ray.get_gpu_ids(), "HCCL actor has no NPUs assigned" |
There was a problem hiding this comment.
ray.get_gpu_ids() seems to only get GPU IDs?
Comment on lines
+68
to
+70
| os.environ['MASTER_ADDR'] = '127.0.0.1' | ||
| os.environ['MASTER_PORT'] = '29500' | ||
| os.environ['HCCL_WHITELIST_DISABLE'] = '1' |
There was a problem hiding this comment.
Do we need to make these configurable?
anyscalesam
added
P1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.