Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert export events to proto and flush from background thread #47713

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Sep 17, 2024

Why are these changes needed?

Updated export event write logic to improve performance:

  • Actors: Convert actor table data to export event proto and write log and flush on separate thread.
  • Tasks: Task export event proto is already being created on a separate thread in the task_event_buffer, so only move log and flush to RayEventLog background thread.
  • Nodes and Driver Jobs: No changes here because we aren't too concerned about performance due to relatively lower volume of events.

Improvement in actor creation throughput observed in release tests with FF on: https://buildkite.com/ray-project/release/builds/22806. * Note: This doesn't address regression in actor calls and task latency, that is still being investigated

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 3 commits September 16, 2024 17:41
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri nikitavemuri added the go add ONLY when ready to merge, run all tests label Sep 17, 2024
Nikita Vemuri added 11 commits September 17, 2024 23:39
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri nikitavemuri changed the title [WIP] [Do not merge] Prototype convert export actor event proto and flush on thread Convert export events to proto and flush from background thread Sep 19, 2024
@nikitavemuri nikitavemuri marked this pull request as ready for review September 19, 2024 15:05
@nikitavemuri nikitavemuri requested a review from a team as a code owner September 19, 2024 15:05
Nikita Vemuri added 2 commits September 23, 2024 12:52
Signed-off-by: Nikita Vemuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants