Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] update quick start timeout #47732

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[train] update quick start timeout #47732

merged 2 commits into from
Sep 19, 2024

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Sep 18, 2024 •
edited
Loading

Why are these changes needed?

The time is spent mostly on downloading the dataset to disk, and training times out after 15 seconds.

Bumping to 300 seconds.

Related issue number

Closes #46769

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@matthewdeng matthewdeng added the go add ONLY when ready to merge, run all tests label Sep 18, 2024
@matthewdeng matthewdeng marked this pull request as ready for review September 18, 2024 23:42
hongpeng-guo
hongpeng-guo approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@hongpeng-guo hongpeng-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewdeng matthewdeng merged commit 1e48a03 into ray-project:master Sep 19, 2024
5 checks passed
@matthewdeng matthewdeng deleted the torch-qs-timeout branch September 19, 2024 01:43
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@matthewdeng @hongpeng-guo @ujjawal-khare
[train] update quick start timeout (ray-project#47732)
38feedb 
The time is spent mostly on downloading the dataset to disk, and
training times out after 15 seconds.

Bumping to 300 seconds.

Signed-off-by: Matthew Deng <[email protected]>
Co-authored-by: Hongpeng Guo <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongpeng-guo hongpeng-guo hongpeng-guo approved these changes

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees

@hongpeng-guo hongpeng-guo

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI test linux://python/ray/train:torch_quick_start is flaky
2 participants
@matthewdeng @hongpeng-guo