Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] add dependencies on openssl #47738

Merged
merged 4 commits into from
Sep 23, 2024
Merged

[Serve] add dependencies on openssl #47738

merged 4 commits into from
Sep 23, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Sep 18, 2024 •
edited
Loading

Why are these changes needed?

Add pyOpenSSL dependency for Serve. And update test docker file to use ray[serve-grpc] dependencies.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Sep 18, 2024
@GeneDer GeneDer marked this pull request as ready for review September 23, 2024 14:57
@GeneDer GeneDer requested a review from a team as a code owner September 23, 2024 17:53
aslonnie
aslonnie reviewed Sep 23, 2024
View reviewed changes
python/requirements.txt
@@ -57,3 +57,4 @@ pandas>=1.3
pydantic!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.*,!=2.4.*,<3 # Serve users can use pydantic<2
py-spy>=0.2.0
memray; sys_platform != "win32" # memray is not supported on Windows
pyOpenSSL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the compiled dependency file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it already exist here

ray/python/requirements_compiled.txt

Line 1684 in a31eede

pyopenssl==23.0.0
:)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still needs to be updated to include the line like:

-r /ray/ci/../python/requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the file from https://buildkite.com/ray-project/premerge/builds/29486#01922006-34c9-4366-a8b4-fd1a372567b2 and seems like that's the only change (besides added a new line in the end)

@edoakes edoakes merged commit 98017c3 into ray-project:master Sep 23, 2024
5 checks passed
@GeneDer GeneDer deleted the add-openssl-to-serve branch September 23, 2024 23:06
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
55ceb4c 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
971bd3d 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
511afa1 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
fe19c6a 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
9760e85 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
bba26f8 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
a053556 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
bc27b4c 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] add dependencies on openssl (ray-project#47738)
bc7f7b0 
Add `pyOpenSSL` dependency for Serve. And update test docker file to use
ray[serve-grpc] dependencies.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@aslonnie aslonnie aslonnie approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@ericl ericl Awaiting requested review from ericl

Assignees

@edoakes edoakes

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeneDer @edoakes @aslonnie