Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move export events to separate folder #47747

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nikitavemuri
Copy link
Contributor

Why are these changes needed?

  • Move export events from session_latest/logs/events to session_latest/logs/export_events
  • Keeping both event types in the same folder doesn't cause any issue for Ray -- export event files are already filtered out for /events API in
    all_source_types = set(event_consts.EVENT_SOURCE_ALL)
  • However moving these to a separate folder would be better for existing downstream consumers to avoid handling export events in the events folder if they turn the flag on

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 2 commits September 19, 2024 10:42
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri nikitavemuri added the go add ONLY when ready to merge, run all tests label Sep 19, 2024
Signed-off-by: Nikita Vemuri <[email protected]>
@@ -240,7 +240,7 @@ def job_failed(job_id):
with pytest.raises(AssertionError):
assert_no_user_info_in_logs(USER_SECRET)

assert_no_user_info_in_logs(USER_SECRET, file_whitelist=["runtime_env*.log"])
assert_no_user_info_in_logs(USER_SECRET, file_whitelist=["runtime_env*.log", "event_EXPORT*.log"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating so TestNoUserInfoInLogs::test_basic passes regardless of value of FF

@nikitavemuri nikitavemuri marked this pull request as ready for review September 19, 2024 18:30
@nikitavemuri nikitavemuri requested a review from a team as a code owner September 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants