Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix: Typo and missing import in doc #48311

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Daraan
Copy link

@Daraan Daraan commented Oct 29, 2024

Why are these changes needed?

I realized that the code samples of RLModule were incomplete and missed some imports.

Another code sample lacked a comma for correct syntax.

Related issue number

NA/

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Daraan <[email protected]>
Signed-off-by: Daniel <[email protected]>
@Daraan Daraan changed the title Fix typo and missing import in doc [RLlib] [doc] Fix typo and missing import in doc Jan 13, 2025
@Daraan
Copy link
Author

Daraan commented Jan 31, 2025

@sven1977 Any chance to update the docs with this PR?

@Daraan Daraan changed the title [RLlib] [doc] Fix typo and missing import in doc [doc] fix: Typo and missing import in doc Feb 20, 2025
@Daraan
Copy link
Author

Daraan commented Mar 14, 2025

@sven1977 @maxpumperla @simonsays1980 another friendly poke asking for a review to improve the examples in the documentation.

@jcotant1 jcotant1 added the rllib RLlib related issues label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rllib RLlib related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants