[serve] Add to_object_ref methods to ReplicaResult
#48544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
9 tasks
…es/to-obj-ref-validation
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
zcin
approved these changes
Nov 4, 2024
|
|
||
| @_process_response | ||
| async def get_async(self): | ||
| assert ( | ||
| self._obj_ref is not None or not self._is_streaming | ||
| ), "get_async() can only be called on a non-streaming ActorReplicaResult" | ||
| not self._is_streaming |
There was a problem hiding this comment.
Do we need these assertion statements if they are all going to be caught in to_object_ref and to_object_ref_async?
There was a problem hiding this comment.
probably not, but being explicit doesn't hurt
Co-authored-by: Cindy Zhang <[email protected]> Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…8544) Formalizes the interface for these methods since non-actor `ReplicaResult` implementations like `LocalReplicaResult` won't implement them and need to explicitly raise a good error message when they occur. --------- Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Cindy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Formalizes the interface for these methods since non-actor
ReplicaResultimplementations likeLocalReplicaResultwon't implement them and need to explicitly raise a good error message when they occur.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.