-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vsphere provider supporting Supervisor (k8s) cluster. #49881
base: master
Are you sure you want to change the base?
New vsphere provider supporting Supervisor (k8s) cluster. #49881
Conversation
Signed-off-by: ankitasonawane30 <[email protected]>
Signed-off-by: Roshan Kathawate <[email protected]>
Signed-off-by: Roshan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roshankathawate,
-
Would you mind adding a PR description? I have no context about vSphere, so a PR description would help me better understand this PR.
-
Does it make sense to split this into smaller PRs? I haven't reviewed it yet, but I'm wondering if we can make this large PR easier to review.
-
Do you have any colleagues who could review this PR before I take a look?
Thanks
Hi @kevin85421, Thanks for reviewing the PR. I have tried to provide details in the PR description so you can understand the changes and sorry for not adding those before. I could make smaller PRs but if you see I have only added one new file and most of the other files are either redundant (which are deleted )or are config files. But if you still find it difficult to review let me know and I'll try to make small PRs. Once again thanks for reviewing it. |
Signed-off-by: Roshan <[email protected]>
Why are these changes needed?
Before these changes vSphere provider was using vSphere SDK to create a Ray cluster on vSphere. However, with availability of K8s control plane within the vSphere hypervisor (Supervisor) it is possible to deploy services using k8s operator. These changes are done to make Ray as a Supervior service on vSphere. With these changes Ray cluster is exposed as a k8s custom resource (CR). Instead of using old vSphere SDK to create and manage the cluster, now, the provider create, update, and delete Ray cluster CRs through exposed k8s API.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.