Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Disable callbacks callable check for new api stack #50157

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

n30111
Copy link
Contributor

@n30111 n30111 commented Jan 31, 2025

Why are these changes needed?

This PR fixes the issue reported #50135

Related issue number

#50135

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

anson627 and others added 2 commits January 31, 2025 05:01
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->
This pull request adds a new user guide for setting up an Azure AKS
cluster with GPU nodes specifically for KubeRay, and updates references
in the Kubernetes cluster setup documentation.

New Azure AKS GPU cluster setup guide:

*
[`doc/source/cluster/kubernetes/user-guides/azure-aks-gpu-cluster.md`](diffhunk://#diff-0b5f6ba4d8b02475f9b0eef738c62ac56e9a782d524b8e38eb4fdf453d283630R1-R51):
Added a detailed guide on creating an Azure AKS cluster with GPU nodes
for KubeRay, including steps for creating a resource group, creating an
AKS cluster, adding a GPU node group, and obtaining kubeconfig.

Documentation updates:

*
[`doc/source/cluster/kubernetes/user-guides/k8s-cluster-setup.md`](diffhunk://#diff-4b96da3370400e06b8f96f19d13bfdeb122d56f179b4404ffbf501b17781cb48R11):
Added a reference to the new Azure AKS GPU cluster setup guide in the
list of available cluster setup guides.
*
[`doc/source/cluster/kubernetes/user-guides/k8s-cluster-setup.md`](diffhunk://#diff-4b96da3370400e06b8f96f19d13bfdeb122d56f179b4404ffbf501b17781cb48L29-R31):
Updated the section for setting up an AKS cluster to include a reference
to the new detailed setup guide.
<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?


Updated based on latest AKS public docs

## Related issue number



## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
make sure steps in
[quickstart](https://docs.ray.io/en/latest/cluster/kubernetes/getting-started/raycluster-quick-start.html#kuberay-raycluster-quickstart)
run without issue on AKS cluster

---------

Signed-off-by: Anson Qian <[email protected]>

Signed-off-by: n3011 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants