-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stripe extension #15265
base: main
Are you sure you want to change the base?
Update stripe extension #15265
Conversation
- update changelog. - implement the fill checkout command. GIT_VALID_PII_OVERRIDE - add bradgarropy as a contributor. remove react dev tools. add the fill checkout command. - Initial commit
Thank you for your contribution! 🎉 🔔 @pradeepb28 @farisaziz12 you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
The checks are failing due to some type errors that were present in the application before my changes. Would y'all like me to fix those as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this awesome addition @bradgarropy! Really cool to see someone from the Stripe team introduce new functionality to the Raycast extension.
I haven't touched the extension in a while, so I'm not sure where the type errors have originated from but I'm entirely happy for you to fix them or I can make a commit to your branch with the required changes to get the CI passing. Whatever is easiest 😄
Other than that all looks good to me, I just left a few non-blocking comments as food for thought.
return expiryDate; | ||
}; | ||
|
||
const createAppleScript = (card: Card) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought:
This works great while Raycast is consistently used in the MacOS ecosystem, this might be something we need to revisit down the line when Raycast comes to Windows. We can go with this approach for now.
@bradgarropy I went ahead and adjusted the code to fix the TS issues and ran the build locally on my end to validate all is good. I don't believe I have write access to your fork so feel free to copy the below code for the respective files to fix the issue:
|
Thoughts on a UX improvement if you would like to go the extra mile 😉 Currently, with each command of the extension, you can individually set the environment to From what I remember, at the time of this extension's creation, we didn't have APIs to work around this as commands are their own individual views rather than being routed from a parent component, which means they could not be wrapped in a React context globally for example. We could use the newer |
Co-authored-by: Faris Aziz <[email protected]>
Description
Hey @pradeepb28 and @farisaziz12,
I'm @bradgarropy and I work at Stripe. I ported over our internal
Fill Checkout
command to this public Raycast extension. We thought it would be good to spread this to other developers!Screencast
fill-checkout.mov
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder