Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gumroad extension #15295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

eddiesigner
Copy link

@eddiesigner eddiesigner commented Nov 9, 2024

Description

View your sales and products from Gumroad.

Screencast

gumroad-01
gumroad-02
gumroad-03

Checklist

- Updated readme
- Added assets and metadata
- Fixed linting issues
- Fixed flickering issue
- Persist state
- Implemented pagination and filters for sales
- Implemented sale and product details
- Moved types to their own file
- Remove .idea directory from repository
- first commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Nov 9, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

Copy link
Contributor

@xmok xmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eddiesigner.
I was also working on a Gumroad extension but you beat me to it 👀.
I've left some suggestions which you can look into otherwise I look forward to contributing to your extension in the future!

extensions/gumroad/src/view-sales.tsx Outdated Show resolved Hide resolved
extensions/gumroad/src/product-details.tsx Show resolved Hide resolved
extensions/gumroad/src/view-sales.tsx Outdated Show resolved Hide resolved
…and fixed issue where the loading indicator did not stop after an error
@eddiesigner
Copy link
Author

Hi @xmok,
Thank you so much for your feedback! Your suggestions make sense to me so I have decided to make the relevant changes 👍🏼

@xmok
Copy link
Contributor

xmok commented Nov 12, 2024

Works great!
We could make some changes especially in terms of native pagination and not having to manually "load more" but that can be handled in future updates.
For now, LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants