Add cartesian_product to ParallelIterator #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/iter/cartesian_product.rs
Outdated
Comment on lines
43
to
44
| .into_par_iter() | ||
| .map(|i_item| repeat(i_item.clone()).zip(self.j.clone())) |
There was a problem hiding this comment.
Are the calls to into_par_iter (I already is a ParallelIterator here) and i_item.clone() (repeat will clone it repeatedly, but the first clone seems unnecessary) really required here?
I also think we can use flat_map here instead of map and flatten to possibly benefit from additional optimizations in its implementation.
|
hi, you have to be careful because flat_map can end up being quite expensive compared to flat_map_iter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use cartesian products from itertools and noticed it's not implemented for rayon and has an open issue: #754
I wasn't trying to preallocate, just run a computation in the parallel iterator using a cartesian product generated by ranges. I ended up with this solution that worked for me. It's not implemented for
IndexedParallelIteratorlike suggested in the issue, only forParallelIterator. I don't know enough to know how this would impact performance.Feel free to close this if it's not done properly or out of scope. I'm also open to suggestions if there's a better way to do this.