Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BaseFilterChip): add BaseFilterChip component #2545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saurabhdaware
Copy link
Member

Description

This is base component of FilterChip. We will later build FilterChipDatePicker and FilterChipSelect on top of this component

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 05e72b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

✅ PR title follows Conventional Commits specification.

@tewarig
Copy link
Contributor

tewarig commented Feb 14, 2025

also i think we should add test cases for this component.

@saurabhdaware
Copy link
Member Author

also i think we should add test cases for this component.

Yup. This is Base component. I'll add FilterChipDatePicker and FilterChipSelect on top of this and add tests for all 3 there along with documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants