RDKCOM-5109 RDKBDEV-2974: fix rtrouted crash is seen with an invalid DML query #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-5109 |
pradeeptakdas
force-pushed
the
bbe375
branch
from
f5ff325 to
391c549
Compare
Reason for change: When a dmcli query is made with a large number of dots, rtrouted crashes. For example: dmcli eRT getv Device.NAT.X_CISCO_COM_DMZ.InternalIP The reason is that the tokenizeExpression function splits the datamodel path based on dots and writes into the workTokens array without checking the number of elements being written. This causes a buffer overflow if the number of dots is more than the size of the workTokens array (32). [Solution] Add some checks in tokenizeExpression to avoid overflowing the workTokens and workBuffer arrays. Test Procedure: Run 'dmcli eRT getv Device.NAT.X_CISCO_COM_DMZ.InternalIP' Verify that rtrouted doesn't crash Run 'rbuscli get' with a path that's more than 512 characters in length Verify that rtrouted doesn't crash Test Procedure: Sanity. Risks: None. Signed-off-by: Hamza Ben Zekri <[email protected]>
pradeeptakdas
force-pushed
the
bbe375
branch
from
391c549 to
7a1d705
Compare
pradeeptakdas
changed the title
|
Hey @pradeeptakdas , This is good find and could you please enhance it a bit and share it as appropriate fix? Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
When a dmcli query is made with a large number of dots, rtrouted crashes. For example: dmcli eRT getv Device.NAT.X_CISCO_COM_DMZ.InternalIP
The reason is that the tokenizeExpression function splits the datamodel path based on dots and writes into the workTokens array without checking the number of elements being written.
This causes a buffer overflow if the number of dots is more than the size of the workTokens array (32).
[Solution]
Add some checks in tokenizeExpression to avoid overflowing the workTokens and workBuffer arrays. Test Procedure:
Run 'dmcli eRT getv Device.NAT.X_CISCO_COM_DMZ.InternalIP' Verify that rtrouted doesn't crash
Run 'rbuscli get' with a path that's more than 512 characters in length Verify that rtrouted doesn't crash
Test Procedure: Sanity.
Risks: None.
Signed-off-by: Hamza Ben Zekri [email protected]