-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(projects): add check for finding next relevant page #1192
Draft
MyPyDavid
wants to merge
17
commits into
2.3.0
Choose a base branch
from
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
base: 2.3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(projects): add check for finding next relevant page #1192
MyPyDavid
wants to merge
17
commits into
2.3.0
from
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…current user to core assets
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
November 13, 2024 10:10
9796e9e
to
f3b8850
Compare
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
November 13, 2024 10:18
f3b8850
to
9756d2c
Compare
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
November 14, 2024 14:22
3e06cd8
to
c90ea63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #1191
Adds a method
_find_next_relevant_page
toProjectPageViewSet
to resolve next page already in the ViewSet instead of via responses to the user.Motivation and Context
How has this been tested?
Screenshots (if appropriate)