fix: the month and year cannot be switched after the datepicker is rendered in Calendar #535
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 99.32% 99.33%
=======================================
Files 49 49
Lines 2236 2246 +10
Branches 652 653 +1
=======================================
+ Hits 2221 2231 +10
Misses 13 13
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Vercel 的CI忽略它 |
好的 明白了 |
…ndered in Calendar
edc-hui
force-pushed
the
fix-issue-antd-38731
branch
from
07dbc62
to
dfbe7bd
Compare
|
@afc163 帮忙再看下这次代码可以么 |
|
@zombieJ 看看 |
zombieJ
reviewed
Jan 20, 2023
| @@ -334,8 +336,9 @@ function PickerPanel<DateType>(props: PickerPanelProps<DateType>) { | |||
|
|
|||
| // ============================ Effect ============================ | |||
| React.useEffect(() => { | |||
| if (value && !initRef.current) { | |||
| if (value && !isEqual(generateConfig, value, originalValue.current) && !initRef.current) { | |||
There was a problem hiding this comment.
这个 value object 变化重置是 by design，做 date 判断反而是非预期的。我去那边评论一下~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复ant design 中 Calendar 内渲染 Datepicker 后无法切换月份年份的问题。
fix ant-design/ant-design#38731