generated from react-component/footer
-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:RangePicker the triangle sign was not positioned correctly in some cases #886
Open
bbb169
wants to merge
13
commits into
react-component:master
Choose a base branch
from
bbb169:fix/range-picker-arrow-wrong-position
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1ec2feb
feat: picker need to receive the placement aligned by popup
bbb169 e5f2671
feat: add test cases for rang being realigned
bbb169 1f63ee9
Update src/PickerTrigger/index.tsx
bbb169 18d41e0
chore: optimize range-align.spec.tsx
bbb169 e551d12
fix: avtive bar will be wrong position while init
bbb169 f33f841
fix: simulate parent width for active bar
bbb169 cba76c7
fix: arrow place above while placement is `topRight`
bbb169 7add058
test: move range-align into new-range and fix tests exceed time problem
bbb169 d02ddec
chore: merge two beforeEach hooks logics
bbb169 05eeced
fix: active bar always offset 1px
bbb169 9e4ee41
test: change the proxy `offsetLeft` to proxy `getBoundingClientRect`
bbb169 8f0cdc4
fix: tsc error
bbb169 f6ee130
Merge branch 'master' into fix/range-picker-arrow-wrong-position
bbb169 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉有点复杂,我再想想有没有更简洁的解法。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
想办法给这种自动更换 placement 情况下的 offsetUnit 去反应该就行。