Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel InteractionManager's task on unmount #233

Closed
wants to merge 1 commit into from
Closed

Cancel InteractionManager's task on unmount #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/useInteractionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@ export function useInteractionManager() {
const [complete, updateInteractionStatus] = useState(false)

useEffect(() => {
InteractionManager.runAfterInteractions(() => {
const {cancel} = InteractionManager.runAfterInteractions(() => {
updateInteractionStatus(true)
})

return () => {
cancel?.()
Comment on lines +8 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runAfterInteractions returns a promise and I'm not sure if they are required to have their methods bound so that they work without this being set 🤔

Also, I think that cancel will always be set, right? It's documented as returning a cancelable promise 🤔

What do you think about this instead:

Suggested change
const {cancel} = InteractionManager.runAfterInteractions(() => {
updateInteractionStatus(true)
})
return () => {
cancel?.()
const promise = InteractionManager.runAfterInteractions(() => {
updateInteractionStatus(true)
})
return () => {
promise.cancel()

}
}, [])

return complete
}