Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/Refactor Goal #108

Open
1 of 5 tasks
pvinis opened this issue Dec 18, 2019 · 1 comment
Open
1 of 5 tasks

Cleanup/Refactor Goal #108

pvinis opened this issue Dec 18, 2019 · 1 comment
Assignees
Labels
discussion enhancement New feature or request

Comments

@pvinis
Copy link
Member

pvinis commented Dec 18, 2019

Description

  • We need to refactor the code here, it has become too complex for such a simple project 😬, but I haven't had the time to do it myself yet. Basically I want to have a simple utility thing that fetches the releases, and then generates a list of the versions to be displayed. Then we will have the ui thing that will actually display all that. Then we can actually test the utility part, and the ui I don't care if we test.

  • Also, we need to make the notes/comments/links better. Currently, we can only comment inline on minor versions (as it 0.59.x), but if a file has been touched on 0.59.1 and reverted on 0.59.2, this comment is now broken. We need to make a better plan for this.

  • We got a great idea on twitter https://twitter.com/safaiyeh/status/1205969341969133568?s=20 about adding a text input field that the user can put their app name, and all instances of RnDiffApp will be replaced with that name. Sounds cool, helpful and easy, so let's do it.

  • Write a document about xcodeproj. I explained it in my talk, but I should also write a text and have it here so its easy to find. For now, general explanations are needed. No specific questions to make an FAQ or something.

  • Move to typescript 🙌

@pvinis pvinis self-assigned this Dec 18, 2019
@pvinis pvinis mentioned this issue Jan 2, 2020
2 tasks
@kelset kelset added discussion enhancement New feature or request labels Jan 6, 2020
@safaiyeh
Copy link
Member

Nice!! @Naturalclar thanks for that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants