-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: replace RnDiffApp with entered AppName #111
Feature: replace RnDiffApp with entered AppName #111
Conversation
so good! awesome. I'll test it when I'm home before merging. |
Hi @Naturalclar, thank you for opening this PR. The functionality is pretty useful, however, I would rather have the input for the application name to be under a button (the cog on the top right, for instance) as this is not required for everyone and can be just noise for most of the users. About the warning on the bottom, I like it, I would suggest having it:
What do you think? |
@lucasbento @pvinis As for the warning on the bottom, it's not part of this PR, but I'll gladly make another PR that makes the change you request for :) |
Sounds good! I've added a placeholder to the input form.
I'm wondering what would be the best way to make the form without this error happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR, thank you for your work!
A few things that I would like to be changed:
- The input label doesn't match the others (the version selectors), it currently says
Your AppName:
, I would recommend changing it toWhat's your app name?
; - The spacing between the input and the label doesn't match the selectors either, it would be nice to keep UI consistency.
I'm wondering what would be the best way to make the form without this error happening.
You can use a timeout to only set the app name after the user stops typing: https://stackoverflow.com/a/7849308/4252781, we can try this to see how it looks like, I recommend using 750
instead of 1000
ms.
@pvinis @lucasbento |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks terrific, if I could approve twice I would.
Thanks for this contribution @Naturalclar!
This looks so great ❤️ thanks @Naturalclar 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This PR is part of #108
This adds a text input in the header which allows user to enter their AppName.
All the
RnDiffApp
andrndiffapp
will be replaced with the entered AppName (in lowercase if needed)Test Plan
What are the steps to reproduce?
Checklist