Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package and name to URL params #380

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Apr 11, 2024

Summary

  • Closes How to fill in app name and package inputBox #373
  • Allows for the user to provide query params for package and name in addition to the existing to/from versions
  • Query param values are sent to the input boxes as the default value
  • URL is updated when user updates the What's your app name? and What's your app package? inputs
  • Closely follows the same way the version params worked

Test Plan

upgrade-helper-373.mp4

Important

While testing, I did notice there were parts of the source code that did not receive anything but the placeholder value for the app package identifier com.rndiffapp. This mostly seemed isolated to the Android diffs, where package or namespace is set.

Opened another issue with this info @ #382

What are the steps to reproduce?

  1. Initially add query params to the url, such as http://localhost:3000/?package=com.test.app&name=MyApp
  • Observe that the form contains the passed in values
  • Observe that the Show me how to upgrade! result incorporates these values
  1. Update the inputs (package and/or name) using the form and press Show me how to upgrade!
  • Observe that the URL updates accordingly

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

Copy link
Member

@pvinis pvinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you!

@pvinis pvinis merged commit dbaab4e into react-native-community:master Apr 11, 2024
1 check passed
@markrickert
Copy link
Collaborator

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to fill in app name and package inputBox
3 participants