feat: add package and name to URL params #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
app name
andpackage
inputBox #373package
andname
in addition to the existing to/from versionsWhat's your app name?
andWhat's your app package?
inputsTest Plan
upgrade-helper-373.mp4
Important
While testing, I did notice there were parts of the source code that did not receive anything but the placeholder value for the app package identifier
com.rndiffapp
. This mostly seemed isolated to the Android diffs, wherepackage
ornamespace
is set.Opened another issue with this info @ #382
What are the steps to reproduce?
http://localhost:3000/?package=com.test.app&name=MyApp
Show me how to upgrade!
result incorporates these valuesShow me how to upgrade!
Checklist
I added the documentation inREADME.md
(if needed)