Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some UI design and text for look more professional #91

Closed
wants to merge 1 commit into from
Closed

Fix some UI design and text for look more professional #91

wants to merge 1 commit into from
+25 −26

Conversation

iamtariqul
Copy link

Change UI design

Screenshot from 2021-03-21 21-30-18

@netlify
Copy link

netlify bot commented Mar 21, 2021

Deploy preview for rne-playground processing.

Building with commit 558d3c0

https://app.netlify.com/sites/rne-playground/deploys/605766b26f2f4700076f61f3

Uyadav207
Uyadav207 suggested changes Mar 21, 2021
View reviewed changes
Copy link
Contributor

@Uyadav207 Uyadav207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflict? @tstariqul.

  • Also kindly confirm with the maintainer, if these changes are required...?
  • To resolve conflict kindly syncing the fork with upstream.

package-lock.json
"integrity": "sha512-GNvS7/26WNo0ovZ2vQWRFWJxhyDeBrGakFSX0aCey69B6KtZQh8gaFGF6CutlRjMzVfZTHGU2+0NS8A0dNWhAA==",
"version": "3.3.2",
"resolved": "https://registry.npmjs.org/react-native-elements/-/react-native-elements-3.3.2.tgz",
"integrity": "sha512-bDWQt0WEuJEOrwzSYx0mVBV3aoRtJAsK0Kc2sioMsshSEhPOZK17Ccx+EvLBSpZ9uWxPyx42Z7hUH/8dQNu67g==",
"requires": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are conflicting with the upstream

@piyushdevOP
Copy link

[Modified] UI Text Style Changed for Professional Look #93
@flyingcircle @pranshuchittora Please look into it .
Should I add effects to the blocks to make it more interactive ?

@Uyadav207
Copy link
Contributor

@tstariqul, Please resolve the conflict in these files... and see if is the PR isn't duplicate to #93

package-lock.json
src/containers/Drawer/index.jsx
src/pages/home/index.jsx

@pranshuchittora
Copy link
Member

Oops!
Pls pull the new changes & resolve the conflicts.

@iamtariqul iamtariqul closed this by deleting the head repository Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uyadav207 Uyadav207

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamtariqul @piyushdevOP @Uyadav207 @pranshuchittora