Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: MemoCache.query returns {data, paths} just like denormalize #3372

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Feb 24, 2025

BREAKING CHANGE: MemoCache.query() return value changed

Motivation

Solution

Open questions

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: cd827b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cd827b6 Previous: 66e7336 Ratio
normalizeLong 474 ops/sec (±1.23%) 513 ops/sec (±0.35%) 1.08
infer All 8837 ops/sec (±1.46%) 9082 ops/sec (±1.38%) 1.03
denormalizeLong 248 ops/sec (±2.78%) 259 ops/sec (±2.89%) 1.04
denormalizeLong donotcache 864 ops/sec (±0.43%) 900 ops/sec (±0.46%) 1.04
denormalizeShort donotcache 500x 1346 ops/sec (±0.84%) 1373 ops/sec (±0.37%) 1.02
denormalizeShort 500x 773 ops/sec (±2.25%) 790 ops/sec (±2.12%) 1.02
denormalizeShort 500x withCache 4329 ops/sec (±0.27%) 4524 ops/sec (±0.21%) 1.05
denormalizeLong with mixin Entity 237 ops/sec (±2.33%) 249 ops/sec (±1.85%) 1.05
denormalizeLong withCache 6360 ops/sec (±0.25%) 7731 ops/sec (±0.20%) 1.22
denormalizeLong All withCache 6049 ops/sec (±0.25%) 6402 ops/sec (±0.14%) 1.06
denormalizeLong Query-sorted withCache 5879 ops/sec (±0.61%) 6229 ops/sec (±0.64%) 1.06
denormalizeLongAndShort withEntityCacheOnly 1529 ops/sec (±0.60%) 1624 ops/sec (±0.32%) 1.06
getResponse 5685 ops/sec (±0.63%) 6147 ops/sec (±1.21%) 1.08
getResponse (null) 5218246 ops/sec (±0.55%) 4747177 ops/sec (±0.51%) 0.91
getResponse (clear cache) 244 ops/sec (±1.96%) 248 ops/sec (±1.90%) 1.02
getSmallResponse 2469 ops/sec (±0.27%) 2587 ops/sec (±0.26%) 1.05
getSmallInferredResponse 1873 ops/sec (±0.33%) 1954 ops/sec (±0.52%) 1.04
getResponse Query-sorted 6523 ops/sec (±0.50%) 6191 ops/sec (±0.68%) 0.95
getResponse Collection 6570 ops/sec (±1.20%) 5632 ops/sec (±1.09%) 0.86
get Collection 5873 ops/sec (±0.48%) 4852 ops/sec (±0.64%) 0.83
setLong 480 ops/sec (±0.46%) 513 ops/sec (±0.17%) 1.07
setLongWithMerge 191 ops/sec (±0.35%) 202 ops/sec (±0.36%) 1.06
setLongWithSimpleMerge 200 ops/sec (±1.13%) 213 ops/sec (±0.33%) 1.06
setSmallResponse 500x 864 ops/sec (±0.80%) 881 ops/sec (±0.22%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant