-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort plays by Newest,Oldest,Most Liked,Random #1235
Conversation
@sudipkundu999 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
is this PR ready for Review ? @sudipkundu999 |
Yes, this PR is ready for review @Angryman18 |
@Angryman18 @atapas Please review |
@sudipkundu999 build fails.. please fix the lints locally first |
@atapas I ran |
you need to fix those warning that is the lint error we are talking about |
Hey, but I'm not seeing the error Other warnings were from before. That shouldn't be the reason for build failing |
Also in this screenshot yarn lint throws a warning about the typescript version 5.2.2 which is the latest one and is unsupported by Shouldn't we freeze the typescript version instead of always picking the latest version? |
@sudipkundu999 please align this right.. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments
@supminn Do you have further comments on this? |
no, It looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
Description
Currently, the plays are arranged in the date-time sorted order. The recent play comes in the front.
Fixes #1159
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
/plays
Sort by
dropdown between the Banner and Play list. By defaultNewest
is selected.Oldest
,Most Liked
,Random
to see the plays sort by accordingly.Checklist:
Screenshots or example output