Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add React play api url in .env #1260

Merged
merged 5 commits into from
Oct 9, 2023
Merged

[Fix] Add React play api url in .env #1260

merged 5 commits into from
Oct 9, 2023

Conversation

sudipkundu999
Copy link
Contributor

Description

  • When you want to change the API server to work on a different one than https://api.github.com/repos/reactplay
    we need to make changes in the FW code and modify 4 files.
  • After this, we just need to change the env variable to change the server URL without changing the main application code. If reactplay needs to change the API's URL later, no need to modify the code too.

Fixes #1133

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Changed the environmental variable to some random string and got 404. Entering the correct URL works.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Sep 30, 2023

@sudipkundu999 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 520f6ff
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6523aa533a0ed70008adef2d
😎 Deploy Preview https://deploy-preview-1260--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sudipkundu999
Copy link
Contributor Author

Ready for review.

  • Please add REACT_APP_PLAY_API_URL='https://api.github.com/repos/reactplay' as env variable before deploying.

@sudipkundu999 sudipkundu999 changed the title [Fix] #1133 Add React play api url in .env [Fix] Add React play api url in .env Sep 30, 2023
priyankarpal
priyankarpal previously approved these changes Oct 1, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

joshi-kaushal
joshi-kaushal previously approved these changes Oct 1, 2023
Copy link
Member

@joshi-kaushal joshi-kaushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@priyankarpal
Copy link
Member

Ready for review.

  • Please add REACT_APP_PLAY_API_URL='https://api.github.com/repos/reactplay' as env variable before deploying.

@joshi-kaushal please add it if you have access

@joshi-kaushal
Copy link
Member

Ready for review.

  • Please add REACT_APP_PLAY_API_URL='https://api.github.com/repos/reactplay' as env variable before deploying.

@joshi-kaushal please add it if you have access

No, I don't have access to it...

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudipkundu999 Please take care of this.

.env.development Outdated Show resolved Hide resolved
@atapas atapas merged commit f44efe8 into reactplay:main Oct 9, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code update] Add React play api url in process.env variable
4 participants